Integrated: 8342462: TextAreaSkin: remove USE_MULTIPLE_NODES

Andy Goryachev angorya at openjdk.org
Tue Oct 22 14:28:16 UTC 2024


On Wed, 16 Oct 2024 23:01:39 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> Removed "not yet fully implemented" USE_MULTIPLE_NODES and related code.
> 
> I would like to remove the early unfinished idea of using multiple Text nodes in TextAreaSkin to clean up the code, to make it easier to do fixes for [JDK-8342233](https://bugs.openjdk.org/browse/JDK-8342233) and [JDK-8296266](https://bugs.openjdk.org/browse/JDK-8296266).
> 
> Also some minor cleanup.
> 
> ## Summary of Changes
> 
> - removed USE_MULTIPLE_NODES and code paths that correspond to its `true` value
> - permanently adding one Text node to `paragraphNodes` Group, keeping the latter for compatibility purposes
> - removed any code that scans `paragraphNodes` children
> - using `getTextNode()` in place of `((Text)paragraphNodes.getChildren().get(0))`

This pull request has now been integrated.

Changeset: e2a30740
Author:    Andy Goryachev <angorya at openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/e2a3074029d94e19332ffb1f1a49e94c5e3e5163
Stats:     270 lines in 1 file changed: 27 ins; 176 del; 67 mod

8342462: TextAreaSkin: remove USE_MULTIPLE_NODES

Reviewed-by: kcr

-------------

PR: https://git.openjdk.org/jfx/pull/1601


More information about the openjfx-dev mailing list