RFR: 8091673: Public focus traversal API for use in custom controls [v2]

[Kevin Rushforth]

On Wed, 23 Oct 2024 18:37:03 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Public focus traversal API for use in custom controls
>> 
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal-v3.md
>> 
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/8061673/
>> 
>> And is a scaled down version (with the public traversal policy API removed) of
>> #1555
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   request focus traversal

API changes look good, although I recommend removing what looks like commented out API, complete with an `@since` that is guaranteed to be wrong.

modules/javafx.graphics/src/main/java/javafx/scene/Parent.java line 867:

> 865: //     * @since 24
> 866: //     */
> 867: //    private ObjectProperty<TraversalPolicy> traversalPolicy;

I would remove this rather than leaving in commented out code for  an incomplete implementation of a possible future feature that isn't currently being proposed.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1604#pullrequestreview-2395550551
PR Review Comment: https://git.openjdk.org/jfx/pull/1604#discussion_r1816839018