RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v8]

[Andy Goryachev]

On Fri, 25 Oct 2024 14:27:25 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin/master' into ag.text.layout.api
>>  - Merge remote-tracking branch 'origin/master' into ag.text.layout.api
>>  - remove line spacing
>>  - tests
>>  - whitespace
>>  - caret info
>>  - text line info
>>  - Merge remote-tracking branch 'origin/master' into ag.text.layout.api
>>  - convert to wrapper
>>  - clarify
>>  - ... and 4 more: https://git.openjdk.org/jfx/compare/6b8ee716...eb990081
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/LayoutInfo.java line 54:
> 
>> 52:      * <li>{@code minY} is the ascent of the first line (negative)
>> 53:      * <li>{@code width} the width of the widest line
>> 54:      * <li>{@code height} the sum of all lines height
> 
> Is this correct ? What about spacing between lines, or is that included in the line height of each line?

There is an existing related issues
[JDK-8317120](https://bugs.openjdk.org/browse/JDK-8317120) RFE: TextFlow.rangeShape() ignores lineSpacing
[JDK-8317122](https://bugs.openjdk.org/browse/JDK-8317122) RFE: TextFlow.preferredHeight ignores lineSpacing

so perhaps we need to add a `boolean` argument to qualify whether the return value should include the last line's `lineSpacing` or not.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1596#discussion_r1817244811