RFR: 8091673: Public focus traversal API for use in custom controls [v3]
Andy Goryachev
angorya at openjdk.org
Mon Oct 28 15:55:54 UTC 2024
On Sat, 26 Oct 2024 14:37:49 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ListenerHelper.java line 466:
>
>> 464: callback.accept(n);
>> 465: }
>> 466: };
>
> Any reason you're using a listener instead of a subscription, which is easier to manage and less prone to memory leaks?
the two places that use this mechanism do not use `Subscription`.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1604#discussion_r1819322330
More information about the openjfx-dev
mailing list