RFR: 8313424: JavaFX controls in the title bar [v12]

[Michael Strauß]

On Mon, 28 Oct 2024 18:05:35 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into feature/extended-window
>>  - remove unused code
>>  - small code changes
>>  - GTK: add system menu
>>  - GTK: prevent resizing below window button size, fix crash
>>  - Windows: custom context menu overrides system menu
>>  - Windows: add system menu
>>  - improve documentation
>>  - Improve HeaderBar documentation
>>  - Merge branch 'master' into feature/extended-window
>>  - ... and 3 more: https://git.openjdk.org/jfx/compare/8af1857c...d9c0fe2e
>
> modules/javafx.graphics/src/main/java/javafx/stage/StageStyle.java line 83:
> 
>> 81:      * <p>
>> 82:      * An extended window has the default window buttons (minimize, maximize, close), but no system-provided
>> 83:      * draggable header bar. Applications need to provide their own header bar by placing the {@link HeaderBar}
> 
> this must be emphasized.
> 
> suggestion:  "Applications must provide their own header bar by placing a single instance of the {@link HeaderBar} at the top of the scene graph"
> 
> and may be explain why
> 
> "in order to avoid the platform decorations overlapping the scene nodes" or something to that effect.
> 
> what do you think?

Good idea, I've updated the documentation. I also included a paragraph about the title text.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1819691615