RFR: 8301121: RichTextArea Control (Incubator) [v28]

[Andy Goryachev]

On Fri, 25 Oct 2024 17:50:34 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   break iterator
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/CodeArea.java line 219:
> 
>> 217:      * The font to use for text in the {@code CodeArea}.
>> 218:      * @return the font property
>> 219:      * @defaultValue the Monospaced font with size 12.0 px
> 
> Would a monospaced font the size of the default system font,  `1em`, be a better choice or do you think hard-coding 12 point is best?

It's created with `Font.font("Monospaced", 12.0);` but perhaps it should use "the default size" whatever that means

`Font.font("Monospaced", -1);`

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1821442330