RFR: 8301121: RichTextArea Control (Incubator) [v29]

[Andy Goryachev]

On Tue, 29 Oct 2024 00:37:43 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 41 commits:
>> 
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - break iterator
>>  - consume conditionally
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - ask to save on closing window
>>  - line numbers, highlight paragraph menus
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - whitespace
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - ... and 31 more: https://git.openjdk.org/jfx/compare/dc5df6c1...faabd11e
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/BasicTextModel.java line 52:
> 
>> 50:         /**
>> 51:          * Returns the number of paragraphs in this content.
>> 52:          * @return number of text lines
> 
> Method description says it returns number of paragraphs but return value says it returns lines. What about document with multi-line paragraphs? What will the return value be?

it's the number of paragraphs.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1821444546