RFR: 8342457: Remove calls to doPrivileged in swing

Kevin Rushforth kcr at openjdk.org
Wed Oct 30 17:23:10 UTC 2024


On Mon, 28 Oct 2024 14:59:12 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> Removes doPrivileged in the following module:
> 
> - javafx.swing
> 
> See JDK-8342441 for details.
> 
> As a helpful hint for reviewers, I recommend reviewing this using the "Hide whitespace" option.

Looks good other than the one leftover `@SuppressWarnings` annotation I noted inline

@prsadhuk can you also review?

modules/javafx.swing/src/main/java/javafx/embed/swing/SwingNode.java line 553:

> 551: 
> 552:     @SuppressWarnings("removal")
> 553:     private final EventHandler<FocusUngrabEvent> ungrabHandler = event -> {

The `@SuppressWarnings("removal")` annotation can be removed from the method.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1613#pullrequestreview-2405718007
PR Comment: https://git.openjdk.org/jfx/pull/1613#issuecomment-2447867836
PR Review Comment: https://git.openjdk.org/jfx/pull/1613#discussion_r1823081947


More information about the openjfx-dev mailing list