RFR: 8342914: Remove calls to doPrivileged in swt

Kevin Rushforth kcr at openjdk.org
Wed Oct 30 17:29:13 UTC 2024


On Mon, 28 Oct 2024 14:52:06 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> Removes doPrivileged in the following module:
> 
> - javafx.swt
> 
> See JDK-8342441 for details.
> 
> As a helpful hint for reviewers, I recommend reviewing this using the "Hide whitespace" option.

I left one comment inline about an unused variable that can be removed. There are also leftover `SuppressedWarnings` annotations that can be removed from both files.

@jayathirthrao Can you be the second reviewer?

modules/javafx.swt/src/main/java/javafx/embed/swt/FXCanvas.java line 359:

> 357:             });
> 358:             return null;
> 359:         }, null, FXCANVAS_PERMISSION);

I think `FXCANVAS_PERMISSION` is unused after this and can be removed (along with the related import).

-------------

PR Review: https://git.openjdk.org/jfx/pull/1611#pullrequestreview-2399415528
PR Comment: https://git.openjdk.org/jfx/pull/1611#issuecomment-2447879959
PR Review Comment: https://git.openjdk.org/jfx/pull/1611#discussion_r1819261869


More information about the openjfx-dev mailing list