RFR: 8306707: Support pluggable image loading via javax.imageio [v9]

[Andy Goryachev]

On Wed, 30 Oct 2024 08:02:19 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 21 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into feature/ximageloader
>>  - Merge branch 'master' into feature/ximageloader
>>  - review changes
>>  - scanline stride always measured in bytes
>>  - remove unused code
>>  - fix line endings
>>  - fix line endings
>>  - add support for palette-based image formats
>>  - review changes
>>  - review changes
>>  - ... and 11 more: https://git.openjdk.org/jfx/compare/81d24aa6...9dba94c1
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/iio/javax/XImageLoader.java line 126:
> 
>> 124:             int imageHeight = reader.getHeight(imageIndex);
>> 125:             int[] widthHeight = ImageTools.computeDimensions(
>> 126:                 (int)(imageWidth * screenPixelScale), (int)(imageHeight * screenPixelScale),
> 
> Again is there a possibility of overflow here?

should it be `(int)` (~floor) or `(int)Math.round()` ?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1593#discussion_r1823193928