RFR: 8342453: Remove calls to doPrivileged in javafx.graphics/com.sun.javafx.tk [v2]

Kevin Rushforth kcr at openjdk.org
Thu Oct 31 15:12:39 UTC 2024


On Thu, 31 Oct 2024 15:01:41 GMT, Glavo <duke at openjdk.org> wrote:

>> Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/GlassViewEventHandler.java line 69:
> 
>> 67:     static boolean zoomGestureEnabled;
>> 68:     static boolean rotateGestureEnabled;
>> 69:     static boolean scrollGestureEnabled;
> 
> private static final boolean zoomGestureEnabled = Boolean.valueOf(System.getProperty("com.sun.javafx.gestures.zoom", "false"));
>     private static final boolean rotateGestureEnabled = Boolean.valueOf(System.getProperty("com.sun.javafx.gestures.rotate", "false"));
>     private static final boolean scrollGestureEnabled = Boolean.valueOf(System.getProperty("com.sun.javafx.gestures.scroll", "false"));

Yes, I could have done that, but chose to minimize the diffs in this case. Now that it is integrated, it's probably not worth revisiting.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1608#discussion_r1824645632


More information about the openjfx-dev mailing list