RFR: 8342456: Remove calls to doPrivileged in javafx.graphics/other [v2]

Andy Goryachev angorya at openjdk.org
Thu Oct 31 17:47:38 UTC 2024


On Thu, 31 Oct 2024 16:49:28 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Scene: Remove missed doPrivileged use
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/util/Utils.java line 684:
> 
>> 682:     public static boolean hasFullScreenStage(final Screen screen) {
>> 683:         @SuppressWarnings("removal")
>> 684:         final List<Window> allWindows = Window.getWindows();
> 
> After this change there is an unused import of `ACCESS_WINDOW_LIST_PERMISSION` and the `SuppressWarnings` annotation is no longer needed.

I would suggest to double check the unused imports and unneeded `@SuppressWarning`s after we are through with the partial changes, in a separate ticket.  Eclipse can be configured to show these as warnings.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1619#discussion_r1824905782


More information about the openjfx-dev mailing list