RFR: 8342456: Remove calls to doPrivileged in javafx.graphics/other [v2]
Kevin Rushforth
kcr at openjdk.org
Thu Oct 31 23:17:37 UTC 2024
On Thu, 31 Oct 2024 18:37:14 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Since this is preexisting, do you think it is worth a follow-up issue? Worth noting is that the prints only happen when a debug system property is set.
>>
>> I have a separate question: Is the `finally` statement really needed? Given that `Exception` is caught and ignored, the only thing that adding `finally` will do is run the code if there is an `Error` thrown. That doesn't seem necessary, and also isn't equivalent to the previous code.
>
> well, the original code is just sloppy, but we have a policy of not fixing unrelated issues, or even adding comments pointing out the sloppy code.
>
> in this case, we can probably ignore it - it's probably not worth fixing since it's a debug output.
In this case, I wouldn't mind adding a comment about further follow-up, although I question whether it is worth it. Probably not (so you could just leave it alone).
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1619#discussion_r1825271820
More information about the openjfx-dev
mailing list