RFR: 8339335: set number of parallel jobs when building webkit

Kevin Rushforth kcr at openjdk.org
Tue Sep 3 17:29:23 UTC 2024


On Mon, 2 Sep 2024 07:20:50 GMT, Johan Vos <jvos at openjdk.org> wrote:

> When building webkit, the perl script in `modules/javafx.web/src/main/native/Tools/Scripts/build-webkit` will check for a `-j` argument in `$makeArgs`. If that doesn't exist, it will default to `numberOfCPUs()`.
> This PR passes the `NUM_COMPILE_THREADS` from `build.gradle` to the `build-webkit` script. When not setting `NUM_COMPILE_THREADS` explicitly,it will default to the number of CPU's as well, hence it will have the same behavior as without this PR.
> When setting `NUM_COMPILE_THREADS` explicitly, the provided number will be used by cmake as well now.

Presuming that my testing shows no problems, I propose the following:

1. I will close [JDK-8089417](https://bugs.openjdk.org/browse/JDK-8089417) as "Cannot reproduce"
2. I will file a new bug to remove the workaround that currently disabled parallel compilation on mac for the graphics module (I think that's cleaner from a bookkeeping perspective than repurposing JDK-8089417)
3. You can add the removal of the logic that forced `NUM_COMPILE_THREADS` to 1 on macOS to this PR, and `/issue add` the new JBS issue

Thoughts?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1554#issuecomment-2327063495


More information about the openjfx-dev mailing list