RFR: 8332895: Support interpolation for backgrounds and borders [v29]

[Michael Strauß]

On Wed, 4 Sep 2024 21:12:00 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refactoring
>
> build.gradle line 4378:
> 
>> 4376:     options.tags("implSpec:a:Implementation Requirements:")
>> 4377:     options.tags("implNote:a:Implementation Note:")
>> 4378:     options.tags("interpolationType:a:Interpolation type:")
> 
> should this use title case?

Changed as suggested. The style across the documentation is a bit inconsistent, but seems to prefer title case.

> modules/javafx.base/src/test/java/test/util/ReflectionUtils.java line 62:
> 
>> 60:         }
>> 61: 
>> 62:         throw new AssertionError("Field not found");
> 
> suggestion:
> `throw new AssertionError("Field not found:" + fieldName);`

Changed as suggested.

> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 9041:
> 
>> 9039:     }
>> 9040: 
>> 9041:     private TransitionTimerCollection transitionTimers;
> 
> Would it make more sense to move this to the `miscProperties`?
> 
> I'd expect there will typically be a few nodes with transition times, but thousands of Nodes in total.

Sure, we can do that.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1522#discussion_r1744655402
PR Review Comment: https://git.openjdk.org/jfx/pull/1522#discussion_r1744655501
PR Review Comment: https://git.openjdk.org/jfx/pull/1522#discussion_r1744655604