RFR: 8332895: Support interpolation for backgrounds and borders [v30]

Michael Strauß mstrauss at openjdk.org
Thu Sep 5 18:58:17 UTC 2024


On Thu, 5 Sep 2024 16:18:34 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   changes per review
>
> modules/javafx.graphics/src/test/java/test/javafx/css/StyleableProperty_transition_Test.java line 198:
> 
>> 196:     void setup() {
>> 197:         toolkit = (StubToolkit)Toolkit.getToolkit();
>> 198:         scene = new Scene(new Group());
> 
> should we `hide` stage in `@AfterEach` ?
> probably applies to other tests

I'm already doing this in `@AfterEach` by calling `stage.close()`, which is equivalent to `hide()`.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1522#discussion_r1746017559


More information about the openjfx-dev mailing list