RFR: 8339603: Seal the class hierarchy of Node, Camera, LightBase, Shape, Shape3D

[Kevin Rushforth]

On Fri, 6 Sep 2024 16:23:22 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

> > "should" and "may" are not the same as "must" and "will".
> 
> I think this is just suboptimal language, and not a material distinction. You _will_ get a runtime error if you use it in any meaningful way. Anyway, if a developer _really_ wants to create an instance of `Node`, they can use the non-exported `AbstractNode` at their own peril.

Indeed it is a case of suboptimal language. The intention was to make it clear that this is _not_ supported. Period. And it isn't in any meaningful way. If there are corner cases where we miss throwing an exception, that is a bug.

There might be other reasons to not make this change -- I haven't formed an opinion yet -- but concern over compatibility isn't one of them.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1556#issuecomment-2334415657