RFR: 8301121: RichTextArea Control (Incubator) [v7]

[Andy Goryachev]

On Fri, 6 Sep 2024 21:57:16 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>> 
>>  - fixes and review comments
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - improved vertical scrolling
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - cleanup
>>  - navigation
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - whitespace
>>  - update + review comments
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - ... and 2 more: https://git.openjdk.org/jfx/compare/5caa606d...bc1615c0
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/RichTextArea.java line 1143:
> 
>> 1141:      * removing the current selection.
>> 1142:      * <p>
>> 1143:      * This method does nothing if either control or the model is not editable, or the caret position is {@code null}.
> 
> As implemented, this method will do the copy, but not the associated delete. Is this intentional? If so, the spec should be changed to clarify that (else the spec is correct and the impl is wrong).

clarified.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1750536067