RFR: 8323706: Remove SimpleSelector and CompoundSelector classes [v9]

Andy Goryachev angorya at openjdk.org
Mon Sep 9 17:01:27 UTC 2024


On Mon, 9 Sep 2024 16:33:31 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> I don't think that would matter much.  This error will only ever be interpreted by programmers, I'm sure they'll be able to understand what's going on.
>
> Agreed. This should never happen, and if it does, the difference between a hex and decimal printout for the erroneous value wouldn't matter.

I disagree, especially since the target audience is developers.  When this happens and the dev needs to diagnose, hex is better: some things become immediately obvious, and some can be found in the binary viewer which is always in hex.  I don't understand why you resist.

Will re-approve if you decide to fix it.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1333#discussion_r1750606583


More information about the openjfx-dev mailing list