RFR: 8337328: JavaFX build uses deprecated features that will be removed in gradle 9

[Kevin Rushforth]

On Mon, 9 Sep 2024 16:47:21 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

> Following 2 warnings are observed with the JavaFX build.
> These warnings need to be addressed for updating to Gradle 9.0 in future. 
> 
> 1. The org.gradle.api.plugins.JavaPluginConvention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.9/userguide/upgrading_version_8.html#java_convention_deprecation
> `=>>` This warning gets fixed by the change on line number 2111 in build.gradle
> 
> 2. The automatic loading of test framework implementation dependencies has been deprecated. This is scheduled to be removed in Gradle 9.0. Declare the desired test framework directly on the test suite or explicitly declare the test framework implementation dependencies on the test's runtime classpath. Consult the upgrading guide for further information: https://docs.gradle.org/8.9/userguide/upgrading_version_8.html#test_framework_implementation_dependencies
> `=>>` This warning gets fixed by the change on line number 2128 in build.gradle. It also requires the verification metadata to be updated.
> 
> Verification:
> 1. Verify that build completes successfully
> 2. Above two warnings are not observed in build log.
> 3. This warning message is NOT observed in build log: Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

Looking at the GHA logs, the warnings are gone on macOS and Linux, but there is still at least one warning on Windows:


2024-09-09T16:44:02.4582769Z Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
2024-09-09T16:44:02.4583540Z 
2024-09-09T16:44:02.4584686Z You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
2024-09-09T16:44:02.4585790Z 
2024-09-09T16:44:02.4586846Z For more on this, please refer to https://docs.gradle.org/8.9/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
2024-09-09T16:44:02.4588091Z 
2024-09-09T16:44:02.4588292Z BUILD SUCCESSFUL in 6m 51s

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1559#issuecomment-2339009120