RFR: 8339550: Enable javac lint options for tests

Kevin Rushforth kcr at openjdk.org
Fri Sep 13 14:58:23 UTC 2024


This PR enables the `removal` lint option, along with `-Werror`, for compiling shims and test classes. In order to do that, I had to also do the following:

* Disable the `options` lint warning as is done for the `javafx.swing` module, and for the same reason: using `-source NN -release NN` produces a warning that we know about and don't care to see (and will fail the build with `-Werror`)
* Change the `apiguardian` dependency from `testRuntimeOnly` to `testImplementation`, since it needs to be a compile-time dependency to avoid many compile-time warnings for a missing annotation
* Add a missing `@SuppressWarnings("removal")` in one place
* Fix the varargs warnings filed in [JDK-8338340](https://bugs.openjdk.org/browse/JDK-8338340)

I tested locally and with our CI test system. The GHA build passes.

-------------

Commit messages:
 - 8338340: [TestBug] fix varargs parameter type warnings
 - 8339550: Enable javac lint options for tests

Changes: https://git.openjdk.org/jfx/pull/1565/files
  Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1565&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339550
  Stats: 10 lines in 4 files changed: 3 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/jfx/pull/1565.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1565/head:pull/1565

PR: https://git.openjdk.org/jfx/pull/1565


More information about the openjfx-dev mailing list