RFR: 8090456: Focus Management

[Andy Goryachev]

On Tue, 10 Sep 2024 16:42:22 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Public APIs for focus traversal and the focus traversal policy:
>> 
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/FocusTraversal/FocusTraversal.md
>> 
>> This work is loosely based on the patch
>> https://cr.openjdk.org/~jgiles/8061673/
>
> modules/javafx.graphics/src/main/java/javafx/scene/traversal/TraversalPolicy.java line 51:
> 
>> 49:  * @since 999 TODO
>> 50:  */
>> 51: public abstract class TraversalPolicy {
> 
> Who subclasses this? And for what purpose? This should be documented in the class docs.

added clarifications.

not sure what to say beyond "The base class for any algorithm that determines focus traversal between elements in the JavaFX scene graph."

> modules/javafx.graphics/src/main/java/javafx/scene/traversal/TraversalPolicy.java line 63:
> 
>> 61:      * <ol>
>> 62:      * <li>Find the nearest parent of the "owner" that is handled by this TraversalPolicy (i.e. it's a direct child of the root).
>> 63:      * <li>select the next node within this direct child using the context.selectInSubtree() and return it
> 
> I'm going to need a second pass to understand what this does, but one thing that jumps out at me: what is "context" ? and what is the "selectInSubtree" method? I see no such method in the public API, so this description is not comprehensible (nor suitable for public documentation).

fixed

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1555#discussion_r1759596385
PR Review Comment: https://git.openjdk.org/jfx/pull/1555#discussion_r1759596532