RFR: 8332895: Support interpolation for backgrounds and borders [v36]
Nir Lisker
nlisker at openjdk.org
Sat Sep 14 07:11:17 UTC 2024
On Sat, 14 Sep 2024 06:49:33 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/javafx/animation/Interpolatable.java line 54:
>>
>>> 52: * <td>Two lists are combined by pairwise interpolation. If the start list has fewer elements than
>>> 53: * the target list, the missing elements are copied from the target list. If the start list has
>>> 54: * more elements than the target list, the excess elements are discarded.
>>
>> Are the elements within the lists interpolated as well? For example, if one list is `[red, blue]` and the other is `[green]`, then `blue` is discarded as excess, but will `red` be linearly interpolated to `green`?
>>
>> I understand that this specs is for the list itself, but in practice the list can contain interpolatable elements, so it might be clearer to say what happens with them.
>
> Yes, in your example, `red` will be linearly interpolated with `green`.
> That's what I intended to say with "pairwise interpolation": you pair up elements of both lists, and then for each pair, you apply the interpolation rules as described. I don't understand what you mean that the spec "is for the list itself".
Then maybe mention that paired elements are interpolated?
By "this specs is for the list itself" I meant that pairwise interpolation is only relevant for the list itself and not for an element in the list (unless it's a list itself). So a question I would have as a user is what happens with the elements.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1522#discussion_r1759684825
More information about the openjfx-dev
mailing list