RFR: 8339515: [TestBug] Convert web tests to JUnit 5 [v4]

Jay Bhaskar jbhaskar at openjdk.org
Mon Sep 16 15:10:48 UTC 2024


On Mon, 16 Sep 2024 12:54:45 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   converting newly added tests to JUNIT5
>
> modules/javafx.web/src/test/java/test/com/sun/webkit/SharedBufferTest.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
> 
> You removed the starting copyright year, which is not OK. I recommend to revert all of the copyright changes. Then, if you prefer, you can either update it correctly to leave the starting year, or better still, leave it alone and let the script that @arapte runs periodically take care of it.

reverted copyright date change

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1567#discussion_r1761340679


More information about the openjfx-dev mailing list