RFR: 8339515: [TestBug] Convert web tests to JUnit 5 [v6]

[Ambarish Rapte]

On Mon, 16 Sep 2024 15:35:19 GMT, Jay Bhaskar <jbhaskar at openjdk.org> wrote:

>> Successfully converted web tests from JUnit 4 to JUnit 5, ensuring all tests are fully compliant with the JUnit 5 framework.
>
> Jay Bhaskar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
> 
>  - Merge branch 'master' into testsprint
>  - revert copyright date
>  - Revert "copyright year updated along with minor spcae related review"
>    
>    This reverts commit 27275c3e06311b993e7a48eeb8616acc4cc774e8.
>  - converting newly added tests to JUNIT5
>  - resolve conflict
>  - copyright year updated along with minor spcae related review
>  - 8339515: [TestBug] Convert web tests to JUnit 5

Suggesting a few minor changes.

modules/javafx.web/src/test/java/test/javafx/scene/web/FormControlsTest.java line 43:

> 41: import org.junit.jupiter.api.extension.ExtendWith;
> 42: import org.junit.runners.Parameterized.Parameters;
> 43: import org.junit.runners.Parameterized;

These two imports should be removed.

modules/javafx.web/src/test/java/test/javafx/scene/web/HistoryTest.java line 2:

> 1: /*
> 2:  * Copyright (c) 2011, 2022, Oracle and/or its affiliates. All rights reserved.

Year change should be reverted.

modules/javafx.web/src/test/java/test/javafx/scene/web/MiscellaneousTest.java line 2:

> 1: /*
> 2:  * Copyright (c) 2011, 2022, Oracle and/or its affiliates. All rights reserved.

Year change should be reverted.

modules/javafx.web/src/test/java/test/javafx/scene/web/SubresourceIntegrityTest.java line 36:

> 34: import org.junit.jupiter.api.Test;
> 35: import org.junit.jupiter.api.extension.ExtendWith;
> 36: import org.junit.runners.Parameterized.Parameters;

This import should be removed.

-------------

Changes requested by arapte (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1567#pullrequestreview-2307066756
PR Review Comment: https://git.openjdk.org/jfx/pull/1567#discussion_r1761457630
PR Review Comment: https://git.openjdk.org/jfx/pull/1567#discussion_r1761415098
PR Review Comment: https://git.openjdk.org/jfx/pull/1567#discussion_r1761415569
PR Review Comment: https://git.openjdk.org/jfx/pull/1567#discussion_r1761458384