RFR: 8301121: RichTextArea Control (Incubator) [v10]

Andy Goryachev angorya at openjdk.org
Tue Sep 17 21:25:57 UTC 2024


On Fri, 13 Sep 2024 22:03:53 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision:
>> 
>>  - hide impl. detail
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - removed duplicate files
>>  - moved to apps, review comments
>>  - bsd license for sample code
>>  - fixes and review comments
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - improved vertical scrolling
>>  - Merge remote-tracking branch 'origin/master' into 8301121.RichTextArea
>>  - cleanup
>>  - ... and 7 more: https://git.openjdk.org/jfx/compare/e688b168...1aafab27
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/RichTextArea.java line 314:
> 
>> 312:     /**
>> 313:      * Creates the instance with the in-memory model {@link RichTextModel}.
>> 314:      */
> 
> I recommend adding  `@defaultValue`

Can you clarify please?  `@defaultValue` seem to apply to a property, this is a constructor.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1524#discussion_r1764031629


More information about the openjfx-dev mailing list