RFR: 8340208: Additional WebKit 619.1 fixes from WebKitGTK 2.44.4

Kevin Rushforth kcr at openjdk.org
Wed Sep 18 12:25:22 UTC 2024


On Mon, 16 Sep 2024 18:45:45 GMT, Hima Bindu Meda <hmeda at openjdk.org> wrote:

> Updated additional webkit-619.1 fixes from webkitgtk-2.44.4. Build is successful on all platforms.No issues seen

All my testing looks good. The code changes look good with one question that I left.

modules/javafx.web/src/main/native/Source/WebKitLegacy/java/WebCoreSupport/HistoryItemClientJava.cpp line 1:

> 1: #include "HistoryItemClientJava.h"

Where did this file come from? I don't see any changes related to HistoryItemClient in the 2.44.4 release of WebKitGTK?

Presuming we need this file, it will need a proper copyright header.

modules/javafx.web/src/main/native/Source/WebKitLegacy/java/WebCoreSupport/HistoryItemClientJava.h line 1:

> 1: #pragma once

Presuming we need this file, it will need a proper copyright header.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1570#pullrequestreview-2312524694
PR Review Comment: https://git.openjdk.org/jfx/pull/1570#discussion_r1764957413
PR Review Comment: https://git.openjdk.org/jfx/pull/1570#discussion_r1764957887


More information about the openjfx-dev mailing list