RFR: 8339510: [TestBug] Convert system tests to JUnit 5

[Andy Goryachev]

On Wed, 18 Sep 2024 00:20:39 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Converting system tests to junit5.
>> 
>> Please see migration notes:
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>> 
>> ### Notes:
>> 
>> I see shutdown timeout on linux, this will be addressed by [JDK-8340403](https://bugs.openjdk.org/browse/JDK-8340403)
>> 
>> QPathTest > executionError FAILED
>>     org.opentest4j.AssertionFailedError: Exceeded timeout limit of 10000 msec
>>         at app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:39)
>>         at app//org.junit.jupiter.api.Assertions.fail(Assertions.java:134)
>>         at app//test.util.Util.runAndWait(Util.java:156)
>>         at app//test.util.Util.runAndWait(Util.java:127)
>>         at app//test.util.Util.shutdown(Util.java:365)
>>         at app//test.com.sun.marlin.QPathTest.teardownOnce(QPathTest.java:146)
>> 
>> 
>> This test might fail intermittently (?) on linux only:
>> 
>> SetSceneScalingTest > testShowAndSetScene() FAILED
>>     org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
>>         at app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
>>         at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40)
>>         at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:35)
>>         at app//org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:179)
>>         at app//test.robot.javafx.stage.SetSceneScalingTest$TestShowSetSceneApp.test(SetSceneScalingTest.java:129)
>>         at app//test.robot.javafx.stage.SetSceneScalingTest$TestApp.runTest(SetSceneScalingTest.java:89)
>>         at app//test.robot.javafx.stage.SetSceneScalingTest.testShowAndSetScene(SetSceneScalingTest.java:193)
>
> Testing recommendation: do a test run with `gradle -PUNSTABLE_TEST=true` so that all the tests that aren't disabled are run.

@kevinrushforth @lukostyra @arapte please review

jenkins run:
https://java.se.oracle.com/jenkins/rejfx/job/jfx-submit-headful/230/

all green, except for linux, where one test fails consistently (https://bugs.openjdk.org/browse/JDK-8340403), and one seems to be intermittent, as I have not seen it failing during the previous run, and I don't think my changes contributed to the failure.

> tests/system/src/test/java/test/com/sun/javafx/application/ConcurrentStartupTest.java line 46:
> 
>> 44:     @Test
>> 45:     public void testStartupReturnBeforeRunnableComplete() {
>> 46:         assertTimeout(Duration.ofMillis(15000), () -> {
> 
> Why not use an `@Timeout` annotation on the method? That would have been the natural change.

my mistake.  switched to the Timeout annotation.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1569#issuecomment-2359314178
PR Review Comment: https://git.openjdk.org/jfx/pull/1569#discussion_r1765288156