RFR: 8339512: [TestBug] Convert graphics tests to JUnit 5 [v2]

[Lukasz Kostyra]

On Thu, 19 Sep 2024 19:22:07 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/transform/AffineOperationsTest.java line 2781:
> 
>> 2779:     @ParameterizedTest
>> 2780:     @MethodSource("getParams")
>> 2781:     public void nonInvertibleExceptionShoudCancelAtomicOperation(Affine affine) {
> 
> this is one humongous test!!!

It definitely would be on the podium, especially for the parameter expansion... 181 tests times 32 arguments (5792 tests total).

But the undisputed champion is `TransformOperationsTest` with 81 tests times 116 arguments (9396 tests) =)

> modules/javafx.graphics/src/test/java/test/javafx/scene/transform/TransformOperationsTest.java line 2944:
> 
>> 2942:                            boolean isInvertible,
>> 2943:                            Class inverseType) {
>> 2944:         assertCol2D(t, is2d, MatrixType.MT_2D_2x3, 0, null, false, false, false);
> 
> the trick with assigning instance fields might have helped here.
> I discovered this too late myself, and now it's probably too late anyway...

It is either adding a `setUp(...)` line at the start of every function, or editing these. Hard to say which path is really better, so I'd stay with this one.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1566#discussion_r1768609237
PR Review Comment: https://git.openjdk.org/jfx/pull/1566#discussion_r1768611694