RFR: 8339510: [TestBug] Convert system tests to JUnit 5 [v4]

[Andy Goryachev]

On Fri, 20 Sep 2024 15:09:56 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> I still see some unexpected test failures in the (unstable) monocle tests suite.

Speaking of that, I noticed that the number of failed tests varies between invocations on the same machine.  For example with RotateTest on macOS running the command
`gradle -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:cleanTest :systemTests:test -PUNSTABLE_TEST=true --tests test.robot.com.sun.glass.ui.monocle.RotateTest`  I get 5 failures, 10 failures, 6 failures, 7...

Examples:


RotateTest > testRotateLeftBigSteps(TestTouchDevice) > [8] NTrigDevice FAILED
    com.sun.glass.ui.monocle.TestLogShim$TestLogAssertion: Timed out after 3005ms waiting for 'TouchPoint: MOVED 285, 337'
        at app/javafx.graphics at 24-internal/com.sun.glass.ui.monocle.TestLogShim.waitForLog(TestLogShim.java:211)
        at app/javafx.graphics at 24-internal/com.sun.glass.ui.monocle.TestLogShim.waitForLogContaining(TestLogShim.java:237)
        at app/javafx.graphics at 24-internal/com.sun.glass.ui.monocle.TestLogShim.waitForLogContaining(TestLogShim.java:246)
        at app//test.robot.com.sun.glass.ui.monocle.RotateTest.Rotate(RotateTest.java:154)
        at app//test.robot.com.sun.glass.ui.monocle.RotateTest.Rotate(RotateTest.java:221)
        at app//test.robot.com.sun.glass.ui.monocle.RotateTest.testRotateLeftBigSteps(RotateTest.java:316)

RotateTest > testRotateLeftFromMinus140Degrees(TestTouchDevice) > [8] NTrigDevice FAILED
    com.sun.glass.ui.monocle.TestLogShim$TestLogAssertion: Timed out after 3005ms waiting for 'TouchPoint: MOVED 640, 760'
        at app/javafx.graphics at 24-internal/com.sun.glass.ui.monocle.TestLogShim.waitForLog(TestLogShim.java:211)
        at app/javafx.graphics at 24-internal/com.sun.glass.ui.monocle.TestLogShim.waitForLogContaining(TestLogShim.java:237)
        at app/javafx.graphics at 24-internal/com.sun.glass.ui.monocle.TestLogShim.waitForLogContaining(TestLogShim.java:246)
        at app//test.robot.com.sun.glass.ui.monocle.RotateTest.Rotate(RotateTest.java:154)
        at app//test.robot.com.sun.glass.ui.monocle.RotateTest.Rotate(RotateTest.java:217)
        at app//test.robot.com.sun.glass.ui.monocle.RotateTest.testRotateLeftFromMinus140Degrees(RotateTest.java:407)


3 second timeout seems to be sufficient for the purpose, and I don't see any output captured by the TestLogShim.  I haven't looked into the actual tests for long since it's out of scope, but maybe I am doing something wrong.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1569#issuecomment-2364117398