RFR: 8339510: [TestBug] Convert system tests to JUnit 5 [v5]

Andy Goryachev angorya at openjdk.org
Fri Sep 20 18:29:22 UTC 2024


> Converting system tests to junit5.
> 
> Please see migration notes:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
> 
> ### Notes:
> 
> I see shutdown timeout on linux, this will be addressed by [JDK-8340403](https://bugs.openjdk.org/browse/JDK-8340403)
> 
> QPathTest > executionError FAILED
>     org.opentest4j.AssertionFailedError: Exceeded timeout limit of 10000 msec
>         at app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:39)
>         at app//org.junit.jupiter.api.Assertions.fail(Assertions.java:134)
>         at app//test.util.Util.runAndWait(Util.java:156)
>         at app//test.util.Util.runAndWait(Util.java:127)
>         at app//test.util.Util.shutdown(Util.java:365)
>         at app//test.com.sun.marlin.QPathTest.teardownOnce(QPathTest.java:146)
> 
> 
> This test might fail intermittently (?) on linux only:
> 
> SetSceneScalingTest > testShowAndSetScene() FAILED
>     org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
>         at app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
>         at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40)
>         at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:35)
>         at app//org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:179)
>         at app//test.robot.javafx.stage.SetSceneScalingTest$TestShowSetSceneApp.test(SetSceneScalingTest.java:129)
>         at app//test.robot.javafx.stage.SetSceneScalingTest$TestApp.runTest(SetSceneScalingTest.java:89)
>         at app//test.robot.javafx.stage.SetSceneScalingTest.testShowAndSetScene(SetSceneScalingTest.java:193)

Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 24 additional commits since the last revision:

 - Merge remote-tracking branch 'origin/master' into 8339510.junit5.system
 - more fixes
 - rotate test
 - review comments
 - unused imports
 - fixes 4
 - fixes 3
 - fixes 2
 - fixes 1
 - part 12 last
 - ... and 14 more: https://git.openjdk.org/jfx/compare/17dd0938...777620ef

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1569/files
  - new: https://git.openjdk.org/jfx/pull/1569/files/7349f483..777620ef

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1569&range=04
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1569&range=03-04

  Stats: 12729 lines in 163 files changed: 10911 ins; 580 del; 1238 mod
  Patch: https://git.openjdk.org/jfx/pull/1569.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1569/head:pull/1569

PR: https://git.openjdk.org/jfx/pull/1569


More information about the openjfx-dev mailing list