RFR: 8338468: [TestBug] Convert controls tests to JUnit 5 [v3]

Andy Goryachev angorya at openjdk.org
Fri Sep 20 20:31:42 UTC 2024


On Fri, 20 Sep 2024 13:42:28 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> I'm not sure I understand. If removing old/commented out tests is out of scope of this PR then why is this one (and others) removed by this PR?
>
> I agree with @lukostyra -- we should not be removing any commented out tests.

I thought that commented out tests have only historical value (or should be removed).
If not, they should be disabled.
If they are commented out, a comment must be added as to why.

in this case, will apply the change to commented out test.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1561#discussion_r1769219677


More information about the openjfx-dev mailing list