RFR: 8339511: [TestBug] Convert Non parametrized base tests to JUnit 5 [v4]

Kevin Rushforth kcr at openjdk.org
Fri Sep 20 21:11:42 UTC 2024


On Fri, 20 Sep 2024 19:39:38 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   one missing , formating
>
> modules/javafx.base/src/test/java/test/com/sun/javafx/binding/ErrorLoggingUtiltity.java line 28:
> 
>> 26: package test.com.sun.javafx.binding;
>> 27: 
>> 28: import static org.junit.jupiter.api.Assertions.*;
> 
> Noticed the copyright year has not been updated in this file (and I am sure in others too).  Should it be?

No. Let the script do it.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1576#discussion_r1769258747


More information about the openjfx-dev mailing list