RFR: 8339510: [TestBug] Convert system tests to JUnit 5 [v6]

[Kevin Rushforth]

On Mon, 23 Sep 2024 18:38:23 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Converting system tests to junit5.
>> 
>> Please see migration notes:
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>> 
>> ### Notes:
>> 
>> I see shutdown timeout on linux, this will be addressed by [JDK-8340403](https://bugs.openjdk.org/browse/JDK-8340403)
>> 
>> QPathTest > executionError FAILED
>>     org.opentest4j.AssertionFailedError: Exceeded timeout limit of 10000 msec
>>         at app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:39)
>>         at app//org.junit.jupiter.api.Assertions.fail(Assertions.java:134)
>>         at app//test.util.Util.runAndWait(Util.java:156)
>>         at app//test.util.Util.runAndWait(Util.java:127)
>>         at app//test.util.Util.shutdown(Util.java:365)
>>         at app//test.com.sun.marlin.QPathTest.teardownOnce(QPathTest.java:146)
>> 
>> 
>> This test might fail intermittently (?) on linux only:
>> 
>> SetSceneScalingTest > testShowAndSetScene() FAILED
>>     org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
>>         at app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
>>         at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40)
>>         at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:35)
>>         at app//org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:179)
>>         at app//test.robot.javafx.stage.SetSceneScalingTest$TestShowSetSceneApp.test(SetSceneScalingTest.java:129)
>>         at app//test.robot.javafx.stage.SetSceneScalingTest$TestApp.runTest(SetSceneScalingTest.java:89)
>>         at app//test.robot.javafx.stage.SetSceneScalingTest.testShowAndSetScene(SetSceneScalingTest.java:193)
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   30 more

Marked as reviewed by kcr (Lead).

I ran the latest and I now see the missing 30 tests being run.


gradle --continue --info -PTEST_ONLY=true -PFULL_TEST=true -PUSE_ROBOT=true -PUNSTABLE_TEST=true \
    :systemTests:test --tests "test.robot.com.sun.glass.ui.monocle*"


#### master

1773 tests : 56 failures : 495 ignored -- tests run: 1773-495=1278

#### this PR

run 1: 1326 tests : 72 failures: 48 ignored -- tests run: 1326-48=1278
run 2: 1326 tests : 37 failures: 48 ignored -- tests run: 1326-48=1278

All good.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1569#pullrequestreview-2323254703
PR Comment: https://git.openjdk.org/jfx/pull/1569#issuecomment-2369321752