RFR: 8332895: Support interpolation for backgrounds and borders [v36]
Kevin Rushforth
kcr at openjdk.org
Fri Sep 27 20:54:00 UTC 2024
On Sat, 14 Sep 2024 06:54:53 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/javafx/css/TransitionEvent.java line 109:
>>
>>> 107: public TransitionEvent(EventType<? extends Event> eventType,
>>> 108: StyleableProperty<?> property,
>>> 109: String propertyName,
>>
>> Does this break backwards compatibility?
>
> Sure, but I don't really mind:
> 1. `TransitionEvent` is a CSS event, it can not usefully be created by application developers.
> 2. This API (without `propertyName`) will be introduced with JFX 23, so developers will need to hurry if they intend to misuse it until JFX 24 rolls around...
>
> I wouldn't mind removing the public constructor altogether, but this is not something that we usually do for JavaFX events.
It might be best to leave the original constructor, deprecate it for removal, and set the default value of `name` to the empty string. We could then remove it in JavaFX 25.
Either way, this new constructor will need an `@since 24` tag.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1522#discussion_r1779031210
More information about the openjfx-dev
mailing list