Integrated: 8340982: [win] Dead key followed by Space generates two characters instead of one

[Kevin Rushforth]

Gluon maintains JavaFX 17 and 21, so Johan can answer that.

There is no maintainer for the JavaFX 8 or 11 code lines in OpenJDK.

-- Kevin


On 9/30/2024 7:55 AM, Johan Corveleyn wrote:
> On Sat, Sep 28, 2024 at 3:02 PM Martin Fox <mfox at openjdk.org> wrote:
>> On Fri, 27 Sep 2024 14:29:17 GMT, Martin Fox <mfox at openjdk.org> wrote:
>>
>>> The standard across all platforms is:
>>>
>>> - A dead key followed by a composable character generates the composed character. For example, a circumflex dead key followed by an 'e' should generate 'ê'.
>>> - A dead key followed by a character that can't compose with it generates a spacing character followed by the non-composable character. On Windows US International a circumflex dead key followed by a 'q' generates '^q'. The spacing character corresponding to the dead key varies based on the OS and layout.
>>> - An exception is SPACE. On all platforms a dead key followed by SPACE should generate just the spacing version of the dead key but *not* a space character. Users rely on this shortcut to quickly access the character 'hidden' by the dead key.
>>>
>>> The Windows glass code didn't implement the Space exception. This PR fixes that.
>>>
>>> On Windows the US  US International layout. Shift+6 is the dead key for a circumflex diacritic if you want to test out the combinations mentioned above.
>>>
>>> For some reason Windows 11 hides this setting well. To install a US International layout:
>>> - Go to Settings > Time & Language > Language & Region.
>>> - In the entry for English click on the three dots to the far right and select 'Language Options'.
>>> - Scroll down until you see 'Installed keyboards' and select 'Add a keyboard'.
>>> - From the list select "United States - International".
>>> To actually use the layout look to the right of the Task Bar and you should see a button for choosing the layout (it will contain the word "ENG").
>> This pull request has now been integrated.
>>
>> Changeset: 5428f267
>> Author:    Martin Fox <mfox at openjdk.org>
>> URL:       https://git.openjdk.org/jfx/commit/5428f267887ea4098f6c2a87335de7ed9bf5c656
>> Stats:     8 lines in 1 file changed: 5 ins; 0 del; 3 mod
>>
>> 8340982: [win] Dead key followed by Space generates two characters instead of one
>>
>> Reviewed-by: angorya, jhendrikx
>>
>> -------------
>>
>> PR: https://git.openjdk.org/jfx/pull/1584
> Great! Thanks for the quick fix.
>
> Is there any chance this could be backported to JavaFX 8 and 11 (and
> perhaps 21)?
> We're currently still on Java 8, but are working to upgrade to 11 in
> the next half year or so, and possibly on to 21 after that.
>
> I realize this is not such an important issue (it's been there for
> ages). Still, if it's not too much effort, it would help us to get a
> hold on that fix (in an official release) in the near future.
>
> Thanks,