RFR: 8350976: MenuBarSkin: exception initializing in a background thread [v2]
Andy Goryachev
angorya at openjdk.org
Tue Apr 1 15:08:25 UTC 2025
On Tue, 1 Apr 2025 14:36:39 GMT, Jayathirth D V <jdv at openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/master' into 8350976.menubarskin.thread.safety
>> - spelling
>> - use system menu
>> - cleanup
>> - possible fix
>> - test
>
> Previously i had commit until march 26 so again i synced the code to latest master branch build it and then took the changes from this PR(`git fetch https://git.openjdk.org/jfx.git pull/1727/head:pull/1727` & `git checkout pull/1727`) and ran the test and still passes on my macOS 14.7.4 macbook pro laptop.
>
> In the test results also i can see menuBar test as passed.
@jayathirthrao
Are you saying that the test taken from this PR passes when added to the current master branch?
If so, I wonder if the laptop/os version might be relevant: I am testing with macOS 15.3.2 on M1 silicon, and the test from this PR fails with the master branch. (I also do a clean build before running the test). Can you try running on a different machine (maybe Windows?)
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1727#issuecomment-2769686822
More information about the openjfx-dev
mailing list