RFR: 8350976: MenuBarSkin: exception initializing in a background thread [v2]

[Kevin Rushforth]

On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Allows MenuBar to be created in a background thread by delaying MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the scene graph.
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into 8350976.menubarskin.thread.safety
>  - spelling
>  - use system menu
>  - cleanup
>  - possible fix
>  - test

I also have macOS 14 (14.7.4 to be exact). `NodeInitializationStressTest.menuBar` test fails consistently for me without this fix and passes with the fix.

@jayathirthrao Can you double-check that you were actually running the version of the test from this PR (without the fix)? The easiest way to do that, which will also save you a bunch of time, is to run just that one test method (although it fails for me if I run the whole thing, `NodeInitializationStressTest` takes nearly 10 minutes on my system).


gradle --continue --info -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:cleanTest :systemTests:test \
--tests test.robot.javafx.scene.NodeInitializationStressTest.menuBar

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1727#issuecomment-2770237809