Integrated: 8352982: gradle TEST_SDK_PATH param doesn't work with relative paths
Ambarish Rapte
arapte at openjdk.org
Thu Apr 3 14:19:00 UTC 2025
On Tue, 1 Apr 2025 06:36:24 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
> Issue:
> The test execution fails when a relative path is specified a relative path for `TEST_SDK_PATH`.
> For example:
> 1. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**..**/jfx1/build test
> 2. gradle -PTEST_ONLY=true -PTEST_SDK_PATH=**~**/jfx1/build test
>
> Solution:
> Convert the relative path to an absolute path.
>
> More about fix:
> The property TEST_SDK_PATH belongs to the root project rt in build.gradle.
> If we modify this property in build.gradle, it does not reflect in the child projects. The child projects for example graphics, controls would still have the value of TEST_SDK_PATH before modification.
> To solve this, I Introduced a new variable in build.gradle `TEST_SDK_DIR`. It would hold the modified value of `TEST_SDK_PATH` and gets correctly reflected across all sub-projects.
>
> Verified that both relative paths and absolute path work fine after this change.
This pull request has now been integrated.
Changeset: c0db2dcd
Author: Ambarish Rapte <arapte at openjdk.org>
URL: https://git.openjdk.org/jfx/commit/c0db2dcda40db09bbcb9ec12a549fefa85e4325e
Stats: 18 lines in 1 file changed: 6 ins; 0 del; 12 mod
8352982: gradle TEST_SDK_PATH param doesn't work with relative paths
Reviewed-by: kcr
-------------
PR: https://git.openjdk.org/jfx/pull/1751
More information about the openjfx-dev
mailing list