RFR: 8234153: [TEST_BUG] Rewrite Popup_parentWindow_Test

Lukasz Kostyra lkostyra at openjdk.org
Mon Apr 7 07:06:06 UTC 2025


On Sat, 5 Apr 2025 07:36:58 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> modules/javafx.graphics/src/test/java/test/javafx/stage/Popup_owner_Test.java line 55:
>> 
>>> 53:  * Instead we rely on checking this manually.
>>> 54:  */
>>> 55: public final class Popup_owner_Test {
>> 
>> minor: maybe `Popup_Owner_Test`?
>
> We do seem to have this funny-looking `PascalCase_camelCase_Test` convention in several places.

Yeah I mostly followed the convention of `Popup_parentWindow_Test`. I assumed the original followed `ClassToTest_propertyName_Test` convention and since this one tests `ownerWindow` and `ownerNode` properties at the same time, the name got reduced to `owner`.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1763#discussion_r2030577613


More information about the openjfx-dev mailing list