RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v6]

[Ambarish Rapte]

On Sat, 5 Apr 2025 05:27:40 GMT, Jay Bhaskar <jbhaskar at openjdk.org> wrote:

>> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing deprecated APIs, updating assertions, and refactoring test structures to align with JUnit 5's improved features.
>
> Jay Bhaskar has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - remove whitespace
>  - change according to review

Here are few more junit4 imports that should be removed too.
Please take a look.

- modules/javafx.base/src/test/java/test//javafx/binding/When_Boolean_Test.java:77:        org.junit.Assert.assertEquals(expected, binding.getValue());
- modules/javafx.base/src/test/java/test//javafx/binding/When_Object_Test.java:78:        org.junit.Assert.assertEquals(expected, binding.getValue());
- modules/javafx.base/src/test/java/test//javafx/binding/When_String_Test.java:77:        org.junit.Assert.assertEquals(expected, binding.getValue());
- modules/javafx.base/src/test/java/test//javafx/beans/value/ObservableValueSubscriptionsTest.java:28:import static org.junit.Assert.assertNull;
- modules/javafx.base/src/test/java/test//javafx/collections/ObservableSubListIteratorTest.java:37:import static org.junit.Assert.assertEquals;

modules/javafx.base/src/test/java/test/javafx/util/converter/DateStringConverterTest.java line 38:

> 36: import javafx.util.converter.DateStringConverter;
> 37: import javafx.util.converter.DateTimeStringConverterShim;
> 38: import static org.junit.Assert.*;

This import should be removed.

modules/javafx.base/src/test/java/test/javafx/util/converter/DateTimeStringConverterTest.java line 38:

> 36: import javafx.util.converter.DateTimeStringConverter;
> 37: import javafx.util.converter.DateTimeStringConverterShim;
> 38: import static org.junit.Assert.*;

This import should be removed.

-------------

Changes requested by arapte (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1759#pullrequestreview-2746247876
PR Review Comment: https://git.openjdk.org/jfx/pull/1759#discussion_r2030901025
PR Review Comment: https://git.openjdk.org/jfx/pull/1759#discussion_r2030901596