RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v8]

[Andy Goryachev]

On Mon, 7 Apr 2025 12:26:33 GMT, Jay Bhaskar <jbhaskar at openjdk.org> wrote:

>> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing deprecated APIs, updating assertions, and refactoring test structures to align with JUnit 5's improved features.
>
> Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   reorder imports

looks good now, with two very minor suggestions (will re-approve if you decide to update).  thanks!

modules/javafx.base/src/test/java/test/javafx/util/converter/DateStringConverterTest.java line 61:

> 59:     }
> 60: 
> 61:     public static Collection implementations() {

very minor: can be `private`

modules/javafx.base/src/test/java/test/javafx/util/converter/DateTimeStringConverterTest.java line 65:

> 63:     }
> 64: 
> 65:     public static Collection implementations() {

very minor: can be `private`

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1759#pullrequestreview-2747466956
PR Review Comment: https://git.openjdk.org/jfx/pull/1759#discussion_r2031627362
PR Review Comment: https://git.openjdk.org/jfx/pull/1759#discussion_r2031627741