RFR: 8313424: JavaFX controls in the title bar [v60]
Andy Goryachev
angorya at openjdk.org
Mon Apr 7 19:29:35 UTC 2025
On Mon, 7 Apr 2025 19:02:21 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/layout/HeaderBar.java line 854:
>>
>>> 852: return minimum
>>> 853: ? computeChildMinAreaHeight(child, -1, margin, width, false)
>>> 854: : computeChildPrefAreaHeight(child, -1, margin, width, false);
>>
>> this change is not doc-related - was it somehow omitted from before?
>
> This was a leftover from a merge conflict that was caused by recent changes to the `Region.computeChildMinAreaHeight` and `Region.computeChildPrefAreaHeight` methods. The commit message is just a bit sloppy.
just wanted to make sure it's intended.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r2031881634
More information about the openjfx-dev
mailing list