RFR: 8234153: [TEST_BUG] Rewrite Popup_parentWindow_Test [v3]
Lukasz Kostyra
lkostyra at openjdk.org
Wed Apr 9 08:18:56 UTC 2025
> This change rewrites `Popup_parentWindow_Test` after a-long-time-ago-done changes to Popup public API.
>
> Popup used to have an `owner` and `parentWindow` properties. I couldn't track how far back that change happened so I can't fully say what these Properties actually were, but to my knowledge both properties were replaced by `ownerNode` and `ownerWindow` Properties respectively. New Properties are read-only and are set while calling respective `Popup.show()` - `Popup.show(Node, ...)` sets both Properties, while `Popup.show(Window, ...)` sets only `ownerWindow` Property.
>
> A lot of original test scenarios were cut out because with current Popup API they make little to no sense. Original `Popup_parentWindow_Test` extended `PropertiesTestBase` and ran the regular Property access checks. Those are parametrized and split into four test methods:
> - `testGetBean` - confidence check for whether we can get the Property bean, unnecessary since new tests access the Properties directly
> - `testGetName` - Properties in `PropertiesTestBase` are referred to by String-provided name and Reflection, so this was a confidence check whether those Properties actually exist in the object - unnecessary, since we access the Properties directly
> - `testBinding` - I deemed those not doable, since the Properties we try to access are read-only and cannot be bound to
> - `testBasicAccess` - This is the only test I found that was workable into a reimplementation, and so it is manually reimplemented as `Popup_owner_Test`
>
> Moreover, because of lack of `Popup.setParent()` API I also deemed more complex test scenarios (cases referring to TestScene's `_window` Property) unnecessary. Since there is no `Popup.show(Scene, ...)` those cases were also eliminated. This leaves current test pool into three separate parameters for one, similar test case.
Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:
Copyright header update
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1763/files
- new: https://git.openjdk.org/jfx/pull/1763/files/986a0b78..552d698b
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1763&range=02
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1763&range=01-02
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jfx/pull/1763.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1763/head:pull/1763
PR: https://git.openjdk.org/jfx/pull/1763
More information about the openjfx-dev
mailing list