RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v2]

[Michael Strauß]

On Wed, 9 Apr 2025 08:59:37 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   obj == null
>
> modules/javafx.graphics/src/test/java/test/com/sun/javafx/css/BitSetTest.java line 50:
> 
>> 48:     @Test
>> 49:     void equalsNullShouldBeFalse() {
>> 50:         assertFalse(set.equals(null));
> 
> Isn't `assertNotEquals` more suitable here?

Since this method specifically tests the `equals` method, I like to actually see the method in question.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1766#discussion_r2034847560