RFR: 8354337: GHA: Windows build fails with chmod permission error

[Andy Goryachev]

On Thu, 10 Apr 2025 22:00:35 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> After a recent update by GitHub to the GHA Windows Server 2022 runner, we get the following error in all GHA test runs:
> 
> 
> chmod: changing permissions of '.': Permission denied
> chmod: changing permissions of './bin': Permission denied 
> ...
> 
> 
> This PR disables running `chmod -R` on the `artifacts/sdk` dir when doing a GHA build.
> 
> The `chmod` is only needed when building artifacts for distribution, and we only use the GHA build for sanity testing, so we can avoid this problem by adding a flag that skips the `chmod` if running on GHA. This is a minimally intrusive solution that would restore our ability to run GHA test builds on Windows without affecting the actual JavaFX build.
> 
> I've run a CI build as well as a local build to ensure that the chmod is still being executed.

Marked as reviewed by angorya (Reviewer).

build.gradle line 606:

> 604: // Specifies whether to run "chmod -R artifacts/sdk" as the last step of
> 605: // copying the sdk to the artifacts dir. This is only done on Windows;
> 606: // the flag is ignored on other platforms.

a minor suggestion: mention JBS ticket for the context

-------------

PR Review: https://git.openjdk.org/jfx/pull/1770#pullrequestreview-2758599297
PR Review Comment: https://git.openjdk.org/jfx/pull/1770#discussion_r2038439952