RFR: 8354337: GHA: Windows build fails with chmod permission error [v2]

[Kevin Rushforth]

On Fri, 11 Apr 2025 14:35:46 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> After a recent update by GitHub to the GHA Windows Server 2022 runner, we get the following error in all GHA test runs:
>> 
>> 
>> chmod: changing permissions of '.': Permission denied
>> chmod: changing permissions of './bin': Permission denied 
>> ...
>> 
>> 
>> This PR disables running `chmod -R` on the `artifacts/sdk` dir when doing a GHA build.
>> 
>> The `chmod` is only needed when building artifacts for distribution, and we only use the GHA build for sanity testing, so we can avoid this problem by adding a flag that skips the `chmod` if running on GHA. This is a minimally intrusive solution that would restore our ability to run GHA test builds on Windows without affecting the actual JavaFX build.
>> 
>> I've run a CI build as well as a local build to ensure that the chmod is still being executed.
>
> Kevin Rushforth has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments

Given that this only affects the GHA build on Windows, which is completely broken until this fix goes in, I will waive the 24-hour waiting period.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1770#issuecomment-2797285209