RFR: 8088343: Intermittent unit test failure in javafx.concurrent.ServiceLifecycleTest [v2]
Andy Goryachev
angorya at openjdk.org
Fri Apr 11 17:06:38 UTC 2025
> The code should not set the `Task.state` value to `CANCELLED` if the said task is already `SUCCEEDED` or `FAILED`.
>
> This is a product bug.
>
> Added `@RepeatedTest(50)` to the tests that used to fail intermittently - this made the test failed more reliably without the fix.
Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
- Merge remote-tracking branch 'origin/master' into 8088343.lifecycle
- 8088343
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1769/files
- new: https://git.openjdk.org/jfx/pull/1769/files/bb7c95c0..d605fb92
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1769&range=01
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1769&range=00-01
Stats: 637 lines in 14 files changed: 416 ins; 203 del; 18 mod
Patch: https://git.openjdk.org/jfx/pull/1769.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1769/head:pull/1769
PR: https://git.openjdk.org/jfx/pull/1769
More information about the openjfx-dev
mailing list