RFR: 8354455: [TestBug] Remove JUnit Vintage Engine with JUnit 4 [v2]
Marius Hanl
mhanl at openjdk.org
Sat Apr 12 01:00:33 UTC 2025
On Fri, 11 Apr 2025 21:34:37 GMT, Marius Hanl <mhanl at openjdk.org> wrote:
>> modules/javafx.swt/src/test/java/test/javafx/embed/swt/SWTCursorsTest.java line 44:
>>
>>> 42:
>>> 43: @Rule
>>> 44: public SwtRule ctx = new SwtRule();
>>
>> this looks like a breaking change - what would be the junit5 equivalent of `@Rule`?
>
> `@ExtendWith`, but I think there is no equivalent of a method rule. In any case, another SWT test seems to be just fine without it, so I adapted the pattern to all other tests. We need to check if that works though.
So this was interesting, turns out it wasn't that stable after all even before!
With some adjustments to the Gradle file, I could make the tests work and they are now green.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1774#discussion_r2040474859
More information about the openjfx-dev
mailing list