RFR: 8354480: A Stage should allow simultaneous iconified and maximized states [v2]
Thiago Milczarek Sayao
tsayao at openjdk.org
Mon Apr 14 15:33:11 UTC 2025
On Mon, 14 Apr 2025 15:07:52 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Missed one change
>
> modules/javafx.graphics/src/main/java/com/sun/glass/events/WindowEvent.java line 76:
>
>> 74: case WindowEvent.FOCUS_DISABLED -> "FOCUS_DISABLED";
>> 75: case WindowEvent.FOCUS_UNGRAB -> "FOCUS_UNGRAB";
>> 76: default -> "UNKNOWN";
>
> Just wanted to share, I usually do `"?" + eventType`, or in this case it might be `"UNKNOWN?" + eventType`.
Makes sense, but I think most reviewers would say it's an unrelated change as ask to rollback :)
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1777#discussion_r2042402111
More information about the openjfx-dev
mailing list